When an error occurs during S/MIME file encryption the user should be offered a yes / no message box, which indicates that we can lower the security checks. Make it non VS-NfD compliant (in VS-NfD) mode and try again to encrypt with: GPGME_ENCRYPT_ALWAYS_TRUST.
Description
Description
Revisions and Commits
Revisions and Commits
| rKLEOPATRA Kleopatra | |||
| rKLEOPATRAe4e4615f4fe8 Fix initialization of encryption flags | |||
| rKLEOPATRA9eed4a45ed93 Don't set the AlwaysTrust flag for S/MIME | |||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T6702 Kleopatra: Use GPGME_ENCRYPT_ALWAYS_TRUST | ||
| Resolved | • ebo | T6559 GPGSM: "always trust like override" or "force" option |
Event Timeline
Comment Actions
We just realized that similar to what we had in GpgOL ( https://dev.gnupg.org/T6701 ) that AlwaysTrust is used by default. And this will now result in the behavior which I also mentioned in our meeting that without question it encrypts to any S/MIME certificate. Without any warning that it is not VS-NfD compliant to do so.
This must be fixed because otherwise we show an operation as VS-NfD compliant, e.g. to encrypt to a certificate with a broken CRL. Which is not VS-NfD compliant because the CRL check was not done.
So where encrypt jobs are used we need to check for the protocol and first try to encrypt to S/MIME without ALWAYS_TRUST because otherwise the operation will always go through.
Comment Actions
For testing with file encryption and notepad you can use this chain which is valid but does not provide a valid CRL for us
just please do not send mails to this certificate.Comment Actions
Ok. Both notepad and file encryption now again produce errors as expected. So the new override would just be a new feature and no longer a regression.
We should probably also check KMail though. There might be a similar fix needed although there I am unsure if the old keyresolver does not do a crl check when a certificate is selected.
Comment Actions
Not sure about S/MIME, but for OpenPGP I'm pretty sure that a check is done when a certificate is selected in the old approval dialog (resp. in the key chooser opened from this dialog).