Page MenuHome GnuPG
Create Task
Maniphest T6933

Kleopatra: Change wording for deletion of key on disk when moving to smartcard
Testing, NormalPublic
Actions

Description

Currently the recommended way to move/copy a key to a smart card is to move the subkeys separately. From the subkey details window by right-click -> move to card
When you have done that for a subkey you see:

The wording is problematic. What is meant is the subkey on disk but especially when you delete secret keys you want to be really sure what it is you delete...

Choice is between (numbers added for reference):

  1. - "Create Backup and Delete Key" -> "Do you really want to delete the local copy of the secret key?"
  2. - "Delete Key" -> "Do you really want to delete the local copy of the secret key?" -> yes -> Success message -> abort -> no message
  3. - "Keep Key" -> no feedback

Suggestions:

  1. Backup first
  2. Delete Key on disk (or maybe better "Subkey"?)
  3. Keep Key on disk (or Subkey to be more precise)

Additionally:
If you choose "Keep Key" you do not get a success message for moving the key to the card at all.
You only get that when you delete the key. Only after that a success window opens with "Successfully copied the key to the card." Which is maybe technically correct but I think it would be more clear to use "moved" instead of "copied" here.
Copied suggests that the original still exists. Which would be the case if you do not delete the key on disk, where it is not returned...

Would it be possible to move the success window to the start? Ideally combine it with the window asking what should be done with the key on disk. Then "copied" would be correct, as the original still exists and we do not need additional code paths for the other combinations.

Please move the Success message as described!

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA769037312fcb Don't ask a second time for confirmation if a backup has been created
rKLEOPATRA9e5dd3c32333 Improve "copy/move key to smart card" workflow

Related Objects
Search...

Event Timeline

• ebo created this task.Jan 11 2024, 4:31 PM
• ebo added a parent task: T6785: Kleopatra: Improvements related to smart cards.
• ebo triaged this task as Normal priority.Jan 12 2024, 11:21 AM
• ebo added a subscriber: • ikloecker.
• ikloecker added a comment.Jan 19 2024, 11:40 AM

I don't understand what your comments about the (missing) success window mean. The screenshot that you added to this task is the success window reporting "The key was copied to the card.". It even has the title "Success". As far as I can tell this window is exactly what you describe with

Would it be possible to move the success window to the start? Ideally combine it with the window asking what should be done with the key on disk. Then "copied" would be correct, as the original still exists and we do not need additional code paths for the other combinations.

Is the problem that another success message is shown after deleting the local copy?

• ikloecker claimed this task.Jan 22 2024, 9:45 AM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo added a comment.Jan 22 2024, 12:15 PM

Is the problem that another success message is shown after deleting the local copy?

yes, that one tripped me...
The the issue then is that success for copying the key to card is reported twice if you delete the local copy and only once when you keep it. The second success message should only report that the local copy was deleted.

• ikloecker added a commit: rKLEOPATRA9e5dd3c32333: Improve "copy/move key to smart card" workflow.Jan 23 2024, 11:20 AM
• ikloecker added a commit: rKLEOPATRA769037312fcb: Don't ask a second time for confirmation if a backup has been created.
• ikloecker changed the task status from Open to Testing.Jan 23 2024, 11:24 AM
• ikloecker moved this task from Backlog to WiP on the vsd33 board.

Done.

Changes:

  • Decouple creating a backup of the (secret) key from deleting the copy of the (secret) key stored on disk.
  • Improve the button texts and the messages to make it clearer that the copy stored on the computer's disk can be deleted.
  • Don't ask a second time for confirmation if a backup has been created.
    • If the user has created a backup of the secret key and then chosen to delete the copy on disk then don't annoy them with another request for confirmation. Even if they accidentally chose to delete the copy on disk they can restore it with the backup.
    • If the user hasn't created a backup (that we know of) then we keep requesting confirmation.
• ikloecker moved this task from WiP to Backlog on the vsd33 board.Jan 24 2024, 10:36 AM

Move back to vsd33 Backlog because the changes may have to be merged to a (future) vsd33 branch.

• ikloecker moved this task from Backlog to WiP on the vsd33 board.May 7 2024, 10:44 AM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 1 2024, 3:55 PM
• ikloecker mentioned this in T7395: Prepare Release Notes for Gpg4win 4.4.0 for Kleopatra.Wed, Nov 13, 5:04 PM