Page MenuHome GnuPG

Fix shellcheck warning in gpgrt-config
Closed, ResolvedPublic

Description

The shellckeck running on this script warns about possible misuse of
curly braces literals, which is a common issue in various shell scripts.

This is commit is trying to avoid this warning by explicitly escaping
the curly braces in the pattern matching.

Reading the manual (at least for bash), the curly braces are not
"special characters" so they do not have to be escaped, but escaping
them should not cause any side effects if I am right.

In src/gpgrt-config line 68:
	    \${*}*)
              ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.

https://www.shellcheck.net/wiki/SC1083

Details

Version
master

Event Timeline

gniibe changed the task status from Open to Testing.Feb 1 2024, 2:30 AM
gniibe claimed this task.
gniibe triaged this task as Normal priority.
gniibe added a subscriber: gniibe.

Thank you for the fix. Pushed the change modifying the commit log for the ChangeLog entry.

gpgrt-config is my challenge to provide minimal pkg-config for GnuPG (to allow easier bootstrap of OS development).

werner moved this task from QA to Done on the gpgrt board.