Maniphest T7036

gpgme: gpgme_op_receive_keys does not return an error if keyserver lookup is disabled
Closed, ResolvedPublic
Actions

Assigned To
• ikloecker
Authored By
• ikloecker
Mar 11 2024, 11:34 AM
Tags
Subscribers
• ebo
• ikloecker

Description

gpgme_op_receive_keys does not return an error if keyserver lookup is disabled. It seems that the FAILURE status message is ignored.

How to reproduce:

  • Set keyserver to none in dirmngr.conf
  • Run gpgme/tests/run-receive-keys 94A5C9A03C2FE5CA3B095D8E1FDF723CF462B6B1

Expected result: The command exists with an error message.
Actual result: The command prints an (empty) import result.

Similarly, gpgme/lang/qt/tests/run-receivekeysjob 94A5C9A03C2FE5CA3B095D8E1FDF723CF462B6B1 shows

Result: Success
Details:
GpgME::ImportResult(
[...]

Revisions and Commits

rM GPGME
rM7158397c098b core: Check STATUS_FAILURE in import operations.

Related Objects

Event Timeline

• ikloecker triaged this task as Normal priority.Mar 11 2024, 11:34 AM
• ikloecker created this task.
• ikloecker mentioned this in T7037: Kleopatra: Handle disabled keyserver when updating a certificate.Mar 11 2024, 11:41 AM
• ikloecker mentioned this in T6761: Kleopatra: Handle special keyserver value "none".Mar 11 2024, 11:43 AM
• ikloecker claimed this task.Mar 11 2024, 1:07 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker changed the task status from Open to Testing.Mar 11 2024, 3:45 PM

This can be tested with Kleopatra by configuring an invalid keyserver and then updating an OpenPGP certificate.

• ikloecker added a commit: rM7158397c098b: core: Check STATUS_FAILURE in import operations..Mar 11 2024, 6:00 PM
• ebo added a project: vsd33.Mar 28 2024, 10:24 AM
• ikloecker moved this task from Backlog to WiP on the vsd33 board.May 7 2024, 11:57 AM
• ebo added a subscriber: • ebo.May 17 2024, 2:55 PM

Tested with VS-Desktop-3.2.93.391-Beta:

I get "Update skipped because no OpenPGP keyserver is configured" in Kleopatra when I set keyserver to "none", I guess this means I should close this ticket.

But any other misconfiguration results in "certificate has not changed". Either immediately or - if you have no network connection - after the timeout.

I guess I have to make a new ticket for that (or even two?)
Would that be a gpgme ticket and a companion Kleopatra ticket again? Or does a "unkown server" or a "network not available" error require some other approach?

• ikloecker added a comment.May 17 2024, 3:49 PM
In T7036#186290, @ebo wrote:

Tested with VS-Desktop-3.2.93.391-Beta:

We figured out that this build doesn't include the fix. It uses the latest release of gpgme from November 2023.

• ebo moved this task from WiP to QA on the vsd33 board.Jun 10 2024, 9:23 AM
• ebo closed this task as Resolved.Aug 2 2024, 4:14 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

with gpg4win-Beta-41:

With a typo in the configured keyserver you now get something like "Update failed: no keysever available"
for value none "Update skipped because no OpenPGP keyserver is configured."

• ebo moved this task from QA to vsd-3.3.0 on the vsd33 board.Aug 2 2024, 4:14 PM
• ebo edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
• ebo moved this task from Backlog to QA for next release on the gpgme board.
• ikloecker mentioned this in T7395: Prepare Release Notes for Gpg4win 4.4.0 for Kleopatra.Nov 14 2024, 9:23 AM