Build failure of gnupg2 with uclibc-ng
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ffontaine
	May 5 2024, 1:48 PM

Description

Build of gnupg2 in version 2.4.5 (with npth) fails since https://git.gnupg.org/cgi-bin/gitweb.cgi?p=npth.git;a=commitdiff;h=02ce6b2d27f91ed6285e4e92d99c21bcc7823c9b because
busy_wait_for is only defined if !HAVE_PTHREAD_MUTEX_TIMEDLOCK. However, busy_wait_for is conditionally used if !HAVE_PTHREAD_MUTEX_TIMEDLOCK, but also if:

!HAVE_PTHREAD_RWLOCK_TIMEDRDLOCK: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=npth.git;a=blob;f=src/npth.c;h=c0ff8da9dae2ed515d9fedfae2f13bccf3f87c50;hb=HEAD#l492
HAVE_PTHREAD_RWLOCK_TRYRDLOCK: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=npth.git;a=blob;f=src/npth.c;h=c0ff8da9dae2ed515d9fedfae2f13bccf3f87c50;hb=HEAD#l537

I don't know how to properly fix this issue (without reverting the commit).

Details

External Link: http://autobuild.buildroot.org/results/9a2/9a27ffde79598a39b4fd55c716978d32d0beb924/build-end.log
Version: 2.4.5

Revisions and Commits

rPTH nPth
	rPTH01f03a91c9bd Return a run-time error if npth_rwlock_timedrdlock is not supported.

Related Objects

Mentioned In: T7387: Release nPth 1.8

Event Timeline

ffontaine created this task.May 5 2024, 1:48 PM

• gniibe claimed this task.May 6 2024, 9:20 AM

• gniibe triaged this task as Normal priority.

Could you show us the build log of nPth, please?

Please test with: rPTH01f03a91c9bd: Return a run-time error if npth_rwlock_timedrdlock is not supported.

• gniibe added a commit: rPTH01f03a91c9bd: Return a run-time error if npth_rwlock_timedrdlock is not supported..May 7 2024, 6:59 AM

• gniibe changed the task status from Open to Testing.May 7 2024, 8:10 AM

Build is still failing even with this commit, here is an extract of npth log:

checking for pthread_mutex_timedlock... yes
checking for pthread_rwlock_rdlock... yes
checking for pthread_rwlock_wrlock... yes
checking for pthread_rwlock_timedrdlock... no
checking for pthread_rwlock_timedwrlock... no
checking for pthread_rwlock_tryrdlock... yes
checking for pthread_rwlock_trywrlock... yes

[...]

make[3] : on entre dans le répertoire « /home/fabrice/buildroot/output/build/libnpth-1.7/src »
/bin/bash ../libtool  --tag=CC   --mode=compile /home/fabrice/buildroot/output/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I..   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O0 -g0  -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wpointer-arith -c -o npth.lo npth.c
/bin/bash ../libtool  --tag=CC   --mode=compile /home/fabrice/buildroot/output/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I..   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O0 -g0  -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wpointer-arith -c -o npth-sigev.lo npth-sigev.c
libtool: compile:  /home/fabrice/buildroot/output/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I.. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O0 -g0 -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wpointer-arith -c npth-sigev.c  -fPIC -DPIC -o .libs/npth-sigev.o
libtool: compile:  /home/fabrice/buildroot/output/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I.. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O0 -g0 -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wpointer-arith -c npth.c  -fPIC -DPIC -o .libs/npth.o
npth.c: In function 'npth_rwlock_timedrdlock':
npth.c:428:9: warning: implicit declaration of function 'busy_wait_for' [-Wimplicit-function-declaration]
  428 |   err = busy_wait_for ((trylock_func_t) pthread_rwlock_tryrdlock, rwlock,
      |         ^~~~~~~~~~~~~

The issue is the same than before: busy_wait_for is called but undefined.

Thank you for testing. Now, I can see the exact reason by your npth log.
Pushed another change: rPTH75c68399ef3b: Fix previous commit.

Thanks, I confirm that this new commit is fixing the issue.

• werner closed this task as Resolved.Sep 25 2024, 4:32 PM

• werner removed a project: gnupg24.

• werner mentioned this in T7387: Release nPth 1.8.Nov 12 2024, 5:47 PM