Page MenuHome GnuPG
Create Task
Maniphest T7114

AM_PATH_LIBGCRYPT does not use gpgrt-config without AM_PATH_GPG_ERROR
Testing, NormalPublic
Actions

Description

Hello,

AM_PATH_LIBGCRYPT uses gpgrt-config iff AM_PATH_GPG_ERROR is invoked first and sets $GPGRT_CONFIG. Otherwise it tries to use libgcrypt-config.

However libgcrypt-config is not installed by default anymore in master (as is already the case for the respective scripts for libksba et.al.) which will leave AM_PATH_LIBGCRYPT broken for projects using libgcrypt but not libgpg-error.

Is there some kind official guidance, should consumers of AM_PATH_LIBGCRYPT move to pkgconf or must AM_PATH_GPG_ERROR be used before AM_PATH_LIBGCRYPT?

Curently the AM_PATH macros of the gnupg projects behave differently, ksba, libassuan and libgcrypt require an explicit AM_PATH_GPG_ERROR while gpgme does not.
cu Andreas

Revisions and Commits

rK libksba
rKc910b8b136b8 m4: Include _AM_PATH_GPGRT_CONFIG definition.
rC libgcrypt
rCad3b599462bd m4: Include _AM_PATH_GPGRT_CONFIG definition.
rA Assuan
rA1c27538e4626 m4: Include _AM_PATH_GPGRT_CONFIG definition.
rM GPGME
rM87061c0260bb gpgme.m4: Set $host correctly always.

Related Objects

Event Timeline

ametzler1 created this task.May 11 2024, 1:19 PM
ametzler1 added a project: libgcrypt.
ametzler1 updated the task description. (Show Details)May 12 2024, 11:23 AM
• werner added a project: gpgrt.May 12 2024, 2:29 PM
• werner added a subscriber: • werner.

I noticed this recently too on some boxes. Thanks for the good decription. This support for pkg-config style .pc files for our config scripts seems to be a never ending story. The alternative name for libgpg-error-config does not make it easier.

ametzler1 added a comment.May 12 2024, 3:57 PM

Just to clarify: I personally think it would be perfectly fine to say that AM_PATH_* is only supported when AM_PATH_GPG_ERROR is also used. Adding an invocation AM_PATH_GPG_ERROR is not a great hassle and alternatively pkg-config/pkgconf exists and works perfectly fine (and is a lot faster).

I just did not want to start checking 70-100 packages in Debian and submitting patches for the broken ones only to find out that my patches were made superfluous by an upstream change.
cu Andreas

• gniibe claimed this task.May 13 2024, 9:57 AM
• gniibe triaged this task as Normal priority.
• gniibe added a comment.EditedMay 14 2024, 4:38 AM

In general, asking an application change is not good. Migrating to pkg-config should be an option (not requirement).
However, it's usually recommended to use libgpg-error when an application is used with libgcrypt/libksba/libassuan.

I'm going to apply changes of:

  • Updating m4 just like in T6273 (of gpgme), so that AM_PATH_GPG_ERROR is not needed for existing applications.
  • Updating documentation for use of PKG_CONFIG_MODULES.

I'll do that for libksba and libassuan, too.

• gniibe added a commit: rCad3b599462bd: m4: Include _AM_PATH_GPGRT_CONFIG definition..May 14 2024, 4:51 AM
• gniibe added a commit: rKc910b8b136b8: m4: Include _AM_PATH_GPGRT_CONFIG definition..May 14 2024, 8:12 AM
• gniibe added a commit: rA1c27538e4626: m4: Include _AM_PATH_GPGRT_CONFIG definition..May 14 2024, 11:53 AM
ametzler1 added a comment.May 14 2024, 6:38 PM

The gcrypt change works for me. Thanks!

• gniibe changed the task status from Open to Testing.May 15 2024, 4:22 AM
ametzler1 added a comment.May 15 2024, 6:27 PM

Ditto for ksba and assuan.

Minor nitpick regarding gpgme: It uses $host without AC_CANONICAL_HOST andf therefore throws a warning if used alone:

*** The config script "/usr/bin/gpgrt-config --libdir=/usr/lib/x86_64-linux-gnu gpgme" was
*** built for x86_64-pc-linux-gnu and thus may not match the
*** used host .
*** You may want to use the configure option --with-gpgme-prefix
*** to specify a matching config script or use $SYSROOT.

(The other m4 snippets have AC_REQUIRE([AC_CANONICAL_HOST]). This would work:

diff
--- a/src/gpgme.m4
+++ b/src/gpgme.m4
@@ -184,7 +184,8 @@ dnl config script does not match the host specification the script
 dnl is added to the gpg_config_script_warn variable.
 dnl
 AC_DEFUN([AM_PATH_GPGME],
-[ AC_REQUIRE([_AM_PATH_GPGME_CONFIG])dnl
+[ AC_REQUIRE([AC_CANONICAL_HOST])dnl
+  AC_REQUIRE([_AM_PATH_GPGME_CONFIG])dnl
   tmp=ifelse([$1], ,1:0.4.2,$1)
• gniibe added a comment.May 16 2024, 2:28 AM

Thank you. Applied by : rM87061c0260bb: gpgme.m4: Set $host correctly always.

• gniibe added a commit: rM87061c0260bb: gpgme.m4: Set $host correctly always..May 16 2024, 2:29 AM