Page MenuHome GnuPG

libassuan-3.0.1: Errant declaration of putc_unlocked in src/assuan-defs.h causes a Darwin build to fail
Closed, ResolvedPublic

Description

libassuan-3.0.1: Errant declaration of putc_unlocked in src/assuan-defs.h causes a Darwin build to fail.

Since putc_unlocked() has been removed, there is an errant declaration for it in src/assuan-defs.h which should also be removed. It causes Darwin builds to fail since Darwin does have putc_unlocked() and the declaration is no longer excluded by the configure logic.

Details

Version
libassuan-3.0.1

Event Timeline

diff --git a/src/assuan-defs.h b/src/assuan-defs.h
index faf9aae..cbc594c 100644
--- a/src/assuan-defs.h
+++ b/src/assuan-defs.h
@@ -431,10 +431,6 @@ char *stpcpy (char *dest, const char *src);
 #define clearenv _assuan_clearenv
 int setenv (const char *name, const char *value, int replace);
 #endif
-#ifndef HAVE_PUTC_UNLOCKED
-int putc_unlocked (int c, FILE *stream);
-#endif
-
 
 #define DIM(v)		     (sizeof(v)/sizeof((v)[0]))
werner added a subscriber: werner.

The use of putc_unlocked has long been removed. So we should also remove the declaration. Normally this does not harm but in your case you may want to pass CFLAGS="-DHAVE_PUTC_UNLOCKED" to make or remove the above declaration.

werner claimed this task.
werner triaged this task as Normal priority.