gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ')
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	debohman
	Jul 9 2024, 1:34 AM

Description

gnupg-2.5.0: Does not build due to undeclared identifier 'environ'

This is similar to T7169.

This is on macOS.

Details

Version: gnupg-2.5.0

Revisions and Commits

rG GnuPG
	rG953dd67368ce Use gpgrt_process_spawn API from libgpg-error.

Related Objects

Mentioned In: T7191: Release GnuPG 2.5.1
Mentioned Here: rG953dd67368ce: Use gpgrt_process_spawn API from libgpg-error.
T7169: libgpg-error 1.50 build issue (spawn-posix.c:345:5: error: use of undeclared identifier 'environ')

Event Timeline

debohman created this task.Jul 9 2024, 1:34 AM

diff --git a/common/exechelp-posix.c b/common/exechelp-posix.c
index 97d8fa4ad..e7109d760 100644
--- a/common/exechelp-posix.c
+++ b/common/exechelp-posix.c
@@ -76,6 +76,7 @@
 #include "sysutils.h"
 #include "exechelp.h"
 
+extern char **environ;
 
 /* Helper */
 static inline gpg_error_t

Thank you for your report. We are about to migrate to use the gpgrt_spawn_process API.
(In our development history, it was originally implemented and tested as gnupg_spawn_process API and moved to libgpg-error.)

Let me change the bug title, since it will be non-issue after the migration.

• gniibe renamed this task from gnupg-2.5.0: Does not build due to undeclared identifier 'environ' to gnupg-2.5.0: Use gpgrt_process_spawn API (was: Does not build due to undeclared identifier 'environ').Jul 9 2024, 3:14 AM

• gniibe added a commit: rG953dd67368ce: Use gpgrt_process_spawn API from libgpg-error..Jul 9 2024, 3:15 AM

Push the change: rG953dd67368ce: Use gpgrt_process_spawn API from libgpg-error.
Please test.

Verified.

• werner mentioned this in T7191: Release GnuPG 2.5.1.Sep 12 2024, 12:22 PM

• gniibe closed this task as Resolved.Fri, Dec 6, 1:05 AM