Page MenuHome GnuPG

gnupg-2.5.0: Does not build due to missing declaration of read and write
Closed, ResolvedPublic

Description

gnupg-2.5.0: Does not build due to missing declaration of read and write

There is a missing include of unistd.h from scd/app.c.

This is on macOS.

Details

Version
gnupg-2.5.0

Event Timeline

diff --git a/scd/app.c b/scd/app.c
index 926ab7925..7bf58a2bd 100644
--- a/scd/app.c
+++ b/scd/app.c
@@ -23,6 +23,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <npth.h>
+#include <unistd.h>
 
 #include "scdaemon.h"
 #include "../common/exechelp.h"
gniibe changed the task status from Open to Testing.Jul 9 2024, 3:52 AM
gniibe claimed this task.
gniibe triaged this task as Normal priority.
gniibe added projects: gnupg, MacOS.
gniibe added a subscriber: gniibe.

Thank you for your report.

Fixed in rG1d5cfa9b7fd2: scd: Add <unistd.h> for read(2) / write(2) .
<unistd.h> is included before the <npth.h>, just as gpg-agent.c and kbxserver.c do.