Page MenuHome GnuPG
Create Task
Maniphest T7225

Kleopatra: Port away from KIconLoader
Closed, ResolvedPublic
Actions

Description

We are trying to phase out/deprecate most of the API in KIconThemes in favor of QIcon API.

Kleopatra is one of the few remaining applications that still uses KIconLoader to load icons in a few places. Please port to QIcon::fromTheme() and let us know about any blockers you encounter

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA452ab51adcea Load the gpg4win logo from an embedded resource file
rKLEOPATRA80691e5f0462 Use QIcon::setFallbackSearchPaths instead of KIconLoader::addAppDir

Event Timeline

nicolasfella created this task.Jul 26 2024, 9:45 PM
• werner added a subscriber: • werner.Jul 27 2024, 5:43 PM

Is the QIcon API available in QT5 ? If not we can't phase that out.

• ikloecker added a subscriber: • ikloecker.Jul 29 2024, 2:10 PM

Yes, we can phase it out in master which is what Nico is talking about and which uses Qt 6/KF6. Nobody is going to remove KIconLoader from KF5.

• aheinecke triaged this task as Normal priority.Jul 30 2024, 2:05 PM
• ikloecker added a commit: rKLEOPATRA80691e5f0462: Use QIcon::setFallbackSearchPaths instead of KIconLoader::addAppDir.Oct 30 2024, 4:42 PM
• ikloecker added a commit: rKLEOPATRA452ab51adcea: Load the gpg4win logo from an embedded resource file.
• ikloecker closed this task as Resolved.Oct 30 2024, 4:59 PM
• ikloecker claimed this task.

The last two usages of KIconLoader have been remove in kleopatra master. (libkleo was already good.)

The only "remaining usage" is the usage of the enum values KIconLoader::Desktop and KIconLoader::Application in combination with KIconDialog::getIcon(). I guess this will stay.