Page MenuHome GnuPG
Create Task
Maniphest T7269

Attachments vanish from forward encrypted message
Open, NormalPublic
Actions

Description

If you forward an encrypted Email the attachments are no longer displayed in the original email.
To recreate :

Press Forward => you see the new mail with the original message and the attachments
Press Cancel => Back to the original with no more attachments
Press Forward => you see the new mail with the original WITHOUT any the attachments.

Deselect email and select again (email gets decrypted again) attachments are back.

If you open the original email in a window of its own you 'll see that the attachments fanish from it during the open-/ceating of the forwarded message.

Event Timeline

mmontkowski created this task.Fri, Aug 23, 12:31 PM
mmontkowski created this object in space Restricted Space.
mmontkowski created this object with edit policy "g10code (Project)".
• aheinecke added a subscriber: • aheinecke.Fri, Aug 23, 12:45 PM

This is caused by "Mail::removeOurAttachments_o()" to avoid that when you forward an encrypted mail, that the decrypted attachments are also attached as well as the original mail. Same goes for send again.

/* Remove our attachments for example if we are a forward of an
   encrypted message or a previously encrypted draft we do not
   want to have the gpgol_mime_structure duplicated. */
removeOurAttachments_o ();

A fix for this would likely be to call Mail::add_attachments_o on the mail that was forwarded after the mail that is forwarded has been created.

• aheinecke renamed this task from Attachments fanish from forward encrypted message to Attachments vanish from forward encrypted message.Fri, Aug 23, 12:47 PM
• werner triaged this task as Normal priority.Fri, Aug 23, 2:32 PM
• werner added projects: Feature Request, Restricted Project.
• werner shifted this object from the Restricted Space space to the S1 Public space.
• werner added a subscriber: • werner.