Page MenuHome GnuPG
Create Task
Maniphest T7485

GpgOL: Using "Permanently decrypt" after cancelling decryption may result in an unreadable mail
Closed, ResolvedPublic
Actions

Description

This issue exists at least since GpgOL version 2.5.6-beta5 (but I guess since the start of this feature in 2020).

In the context menu of a mail in the message list there is an action "Permanently decrypt" at the very bottom.
If you click it after cancelling the decryption of the mail at the pinentry this results in a "decrypted" mail with the content "encryption not possible":

The original mail content is thus permanently lost.

This does not occur in other cases, that is with a not decrypted mail after pinentry timeout or after giving the wrong password. In this cases the function "Permanently decrypt" does nothing without emitting any message.

Revisions and Commits

rO GpgOL
rO9124f33b9737 Catch all canceled decryptions
rOb0e8d879345a Fix T7485, Using "Permanently decrypt" after cancelling ...

Related Objects

Event Timeline

• ebo created this task.Jan 14 2025, 11:30 AM
mmontkowski claimed this task.Jan 27 2025, 9:50 AM
• ebo triaged this task as Normal priority.Jan 29 2025, 9:25 AM
• ebo added a project: vsd33.
• ebo changed the task status from Open to Testing.Mar 21 2025, 1:09 PM
• ebo moved this task from Backlog to WiP on the vsd33 board.
mmontkowski closed this task as Resolved.Mar 24 2025, 9:29 AM
mmontkowski moved this task from Backlog to Done on the gpgol board.

work/markus_montkowski/T7485

59e63ab96e650a6b276c3754809ec33790b0412b

mmontkowski reopened this task as Testing.Mar 24 2025, 9:33 AM
• werner closed this task as Resolved by committing rOb0e8d879345a: Fix T7485, Using "Permanently decrypt" after cancelling ....Tue, Apr 1, 3:09 PM
• werner added a commit: rOb0e8d879345a: Fix T7485, Using "Permanently decrypt" after cancelling ....
• ebo reopened this task as Testing.Thu, Apr 3, 10:29 AM
• werner moved this task from WiP to QA on the vsd33 board.Thu, Apr 3, 11:01 AM
• ebo changed the task status from Testing to Open.Mon, Apr 7, 4:03 PM
• ebo moved this task from QA to Backlog on the vsd33 board.

I see no improvement in VSD-Beta-3.3.90.6, the issue persists.
Btw: Is this maybe related to T7596: GpgOL: Draft is not decrypted after cancelling decryption once?

• ebo added a comment.Mon, Apr 7, 4:28 PM

My above comment is true for the main case described in the ticket, cancelling decryption followed by "permanently decrypt".

What has improved is the case after giving the wrong passphrase: there the action "permanently decrypt" is no longer offered.

• ebo moved this task from Backlog to WiP on the vsd33 board.Wed, Apr 9, 12:05 PM
mmontkowski added a commit: rO9124f33b9737: Catch all canceled decryptions.Wed, Apr 9, 12:35 PM
• ebo closed this task as Resolved.Wed, Apr 9, 3:50 PM
• ebo moved this task from WiP to QA on the vsd33 board.

with VSD-Beta-3.3.90.10:

"Permanently decrypt" is no longer offered for signed+encrypted mails were the decryption was cancelled.
The same as after "Bad passphrase".
And when it is was offered after a successful decryption it did work as expected.

• ebo edited projects, added vsd33 (vsd-3.3.1); removed vsd33.Wed, Apr 9, 3:50 PM