Page MenuHome GnuPG
Create Task
Maniphest T7541

libassuan AC_DEFINE_UNQUOTED m4 fix needs propagating to pinentry and gnupg2
Testing, NormalPublic
Actions

Description

The autoconf script for libassuan were fixed in this commit: https://dev.gnupg.org/rAb9b7f1cf3fd0228fd31cb62a144628ee8ad26953

However, this fix wasn't propagated to other projects that carry the assuan m4 (usually in m4/libassuan.m4), resulting in issues when building with libassuan 3.x like:

In file included from sysutils.c:32:0:
../config.h:650:33: error: token "$" is not valid in preprocessor expressions
 #define LIBASSUAN_API_REQUESTED $req_libassuan_api
                                 ^

The AC_DEFINE_UNQUOTED fix should be added to those projects (and any others I didn't mention).

Revisions and Commits

rG GnuPG
rG0f0e0a732c59 build: Update Libassuan M4 macros
rP Pinentry
rP72b827b33e95 m4: Update libassuan.m4.

Related Objects

Event Timeline

calvin created this task.Feb 25 2025, 10:56 PM
calvin created this object in space S1 Public.
calvin updated the task description. (Show Details)
• gniibe claimed this task.Tue, Mar 4, 11:19 AM
• werner added a commit: rG0f0e0a732c59: build: Update Libassuan M4 macros.Fri, Mar 7, 9:32 AM
• gniibe added a project: gpgme.Mon, Mar 10, 3:47 AM

Thank you for your report.

For GnuPG, it was applied by rG0f0e0a732c59: build: Update Libassuan M4 macros
I pushed the change to pinentry and gpgme.

• gniibe changed the task status from Open to Testing.Mon, Mar 10, 3:49 AM
• gniibe triaged this task as Normal priority.
• gniibe added a commit: rP72b827b33e95: m4: Update libassuan.m4..Mon, Mar 10, 6:55 AM
• gniibe added a comment.Mon, Mar 10, 10:32 AM

GCC allows dollars in identifier, that's the reason why we haven't encountered this issue, I suppose.

calvin added a comment.Mon, Mar 10, 12:47 PM

This was using GCC to build, but on AIX. I believe support for dollar signs in identifiers are platform specific.