Page MenuHome GnuPG
Create Task
Maniphest T7889

libgcrypt: HAVE_BROKEN_MLOCK
Open, HighPublic
Actions

Description

Building with address sanitizer, HAVE_BROKEN_MLOCK is enabled.
In this case secmem does not work (as it's incompatible to address sanitizer). Current code assumes that HAVE_BROKEN_MLOCK is for some particular OS like HP/UX or AIX, so, we need some fix to address address sanitizer case.

Revisions and Commits

rC libgcrypt
rCfe06287003a1 secmem: Handle HAVE_BROKEN_MLOCK for the case with ASAN.

Related Objects

Event Timeline

• gniibe claimed this task.Wed, Oct 29, 7:36 AM
• gniibe triaged this task as High priority.
• gniibe created this task.
• gniibe added a commit: rCfe06287003a1: secmem: Handle HAVE_BROKEN_MLOCK for the case with ASAN..Wed, Oct 29, 7:47 AM
• gniibe added a comment.Wed, Oct 29, 7:48 AM

For the initial attempt, I push: rCfe06287003a1: secmem: Handle HAVE_BROKEN_MLOCK for the case with ASAN.
This is better than nothing.

jukivili added a subscriber: jukivili.Wed, Oct 29, 8:09 PM

There's GCRYPT_IN_ASAN_TEST environment variable check in tests/t-secmen.c and tests/t-sexp.c. Are those check needed after this change? Could they be removed?

• gniibe updated the task description. (Show Details)Thu, Oct 30, 2:21 AM
• gniibe added a comment.Thu, Oct 30, 2:27 AM

@jukivili
Thanks for your feedback.

Are those check needed after this change? Could they be removed?

Those checks are not needed any more, as secmem pretends working with HAVE_BROKEN_MLOCK.
Please remove them.

• gniibe added a comment.Thu, Oct 30, 2:31 AM

Note that:
If we consider backporting this to 1.10/1.11 branch, we also need to apply: rCdef1d4ea8f66: random:jent: Fix build with address sanitizer.