- Use standard KPasswordLineEdit
- Add QLabel for the two text fields
- Bind existing QLabel to their control with setBuddy
Need https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/234
Details
Details
Compile and run fine
Diff Detail
Diff Detail
- Repository
- rGPGPASS GnuPG Password Manager
- Branch
- work/carl/redesign-passwordialog
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
Can we chop this in two (the KPasswordLineEdit thing and the rest) ? I think the rest can go in straight away, but I'd like to play around a bit with KPLE myself.
Comment Actions
I think there is a few things to consider.
Given the amount of actions there is on the 'main view', I'm not sure actions are the right thing to use, an thus not KPasswordLineEdit on the main view. Having two different places for the 'eye-icon' (haha. eye-con) might be confusing.
The Password header should maybe on the same line as the input widget
I'm unsure if one should maybe add a KSeparator after the Character set / length inputs, if there is templates enabled, could be an idea.
Anyways. This is a screenshot of this patch with a couple of templated fields:
(note screenshot is taken without patched KPasswordLineEdit)
I've also started to think that maybe the templated fields should also get a colon, though it is interesting how that plays with RTL environments.