Page MenuHome GnuPG

Allow passing flags to Context::deleteKey
ClosedPublic

Authored by TobiasFella on Nov 13 2025, 12:16 PM.

Details

Reviewers
ikloecker
Summary

Required for passing GPGME_DELETE_FORCE from kleopatra

T7538

Test Plan

Use with other patches; check that deletion works without pinentries

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

TobiasFella created this revision.
ikloecker added inline comments.
src/context.h
253

No int flags in new C++ API please. Add a proper enum class for the delete flags.

TobiasFella marked an inline comment as done.

Feel free to commit/push when you have made the suggested changes. One last thing: Update the NEWS file.

src/context.h
252

Looks good, but let's move it to global.h. It doesn't need to be in the Context namespace.

And I think we don't need the "Delete" prefix of the enum values because all identifiers are scoped with DeletionFlags.

I would use int as underlying type since the gpgme API uses int for flags.

This revision is now accepted and ready to land.Nov 20 2025, 9:32 AM
TobiasFella mentioned this in Unknown Object (Maniphest Task).Nov 24 2025, 9:15 AM