Page MenuHome GnuPG
Feed Advanced Search

Jul 21 2016

justus added a comment to T2405: Possible timing problem with TOFU.

Ok, I pushed a fix related to this problem 45bb9a2a, this had the amusing effect of
reversing the behavior:

% rm -f $GNUPGHOME/tofu.db ; ( g10/gpg --verify --status-fd=1 /tmp/testmsg
)2>/dev/null | grep TOFU_STATS
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 2 1 0 auto 0 0
[GNUPG:] TOFU_STATS_LONG Verified 1 message signed by "Alpha Test (demo key)
<alpha@example.net>"%0Ain the past 0~seconds.
[GNUPG:] TOFU_STATS 2 1 0 auto 0 0
[GNUPG:] TOFU_STATS_LONG Verified 1 message signed by "Alice (demo key)"%0Ain the
past 0~seconds.

The difference stems from tofu_register setting already_verified to 0 for the first
uid, and to 1 for the second. In the former case, show_statistics is asked to ignore
the current message.

I guess the intention was to handle the very first message differently, but now we
are handling the first *uid* upon receiving the first message differently instead.
I'm not sure how to proceed, hence reassigning to Neal.

Jul 21 2016, 6:57 PM · gnupg, gnupg (gpg22), Bug Report
justus added a comment to T2405: Possible timing problem with TOFU.

This is a GnuPG problem:

teythoon@europa ~/repos/g10/gpgme/obj/tests (git)-[master] % rm $GNUPGHOME/tofu.db && ( gpg2 --verify --with-
colons --status-fd=1 /tmp/testmsg )2>/dev/null | grep TOFU_STATS
[GNUPG:] TOFU_STATS 1 0 0 auto
[GNUPG:] TOFU_STATS_LONG Verified 0 messages signed by "Alfa Test (demo key) <alfa@example.net>".
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 1 0 0 none
teythoon@europa ~/repos/g10/gpgme/obj/tests (git)-[master] % rm $GNUPGHOME/tofu.db && ( gpg2 --verify --with-
colons --status-fd=1 /tmp/testmsg && gpg2 --verify --with-colons --status-fd=1 /tmp/testmsg && sleep 1 && gpg2 -
-verify --with-colons --status-fd=1 /tmp/testmsg )2>/dev/null | grep TOFU_STATS
[GNUPG:] TOFU_STATS 1 0 0 auto
[GNUPG:] TOFU_STATS_LONG Verified 0 messages signed by "Alfa Test (demo key) <alfa@example.net>".
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 1 0 0 none
[GNUPG:] TOFU_STATS 2 1 0 auto 1 1
[GNUPG:] TOFU_STATS_LONG Verified 1 message signed by "Alfa Test (demo key) <alfa@example.net>"%0Ain the past
1~second.
[GNUPG:] TOFU_STATS 2 1 0 auto 1 1
[GNUPG:] TOFU_STATS_LONG Verified 1 message signed by "Alpha Test (demo key) <alpha@example.net>"%0Ain the past
1~second.
[GNUPG:] TOFU_STATS 2 1 0 auto 1 1
[GNUPG:] TOFU_STATS_LONG Verified 1 message signed by "Alice (demo key)"%0Ain the past 1~second.

Jul 21 2016, 1:44 PM · gnupg, gnupg (gpg22), Bug Report
justus added projects to T2405: Possible timing problem with TOFU: gnupg (gpg22), gnupg.
Jul 21 2016, 1:44 PM · gnupg, gnupg (gpg22), Bug Report
justus removed a project from T2405: Possible timing problem with TOFU: gpgme.
Jul 21 2016, 1:44 PM · gnupg, gnupg (gpg22), Bug Report

Jul 18 2016

neal added a comment to T2391: Assertion "! db->batch_update" in tofu_closedbs failed (../../g10/tofu.c:1083).

I don't have time to look at this immediately, but it looks related to Werner's
recent change to the tofu db code.

Jul 18 2016, 2:34 PM · gnupg (gpg22), Bug Report, gnupg
justus assigned T2391: Assertion "! db->batch_update" in tofu_closedbs failed (../../g10/tofu.c:1083) to neal.
Jul 18 2016, 2:31 PM · gnupg (gpg22), Bug Report, gnupg
justus added a project to T2391: Assertion "! db->batch_update" in tofu_closedbs failed (../../g10/tofu.c:1083): gnupg (gpg22).
Jul 18 2016, 2:31 PM · gnupg (gpg22), Bug Report, gnupg