kloczek (Tomasz Kłoczko)
User

Projects

User does not belong to any projects.

User Details

User Since: Mar 19 2019, 10:30 PM (300 w, 3 d)
Availability: Available

Recent Activity
View All

May 5 2023

kloczek added a comment to T5606: 2.3.2: compile and link time warnings.

To sort out LTO warning someone needs to make the decision which one routines declarations are correct (those in header files or those in .c files).

May 5 2023, 3:15 PM · Bug Report

kloczek reopened T5606: 2.3.2: compile and link time warnings as "Open".

As I mention LTO warnings are most important.
Just retested 2.4.1 and I still see LTO warnings which still not been sorted out and those warnings are not false positives.

[tkloczko@pers-jacek build]$ rpmbuild -ba --with check --with failing_tests gnupg2.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
     28 -Wunused-result
     22 -Wlto-type-mismatch
      4 -Wenum-int-mismatch

May 5 2023, 3:13 PM · Bug Report

kloczek closed T4602: 2.2.16: test suite fails as Resolved.

Just checked 2.4.1 and looks like now everything is OK.

May 5 2023, 2:57 PM · Fedora, gnupg, Bug Report

Dec 8 2022

kloczek added a comment to T6204: gpgme:python Fix setup.py, using pkg-config (not deprecated gpg-error-config and gpgme-config).

OK I can confirm that with ae9258fb and f1802682 commits I was ble to update my rpm packages to 1.18.0.

Dec 8 2022, 2:20 PM · Python, gpgme

kloczek added a comment to T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config.

I've hit that issu on downloading two times so I think that there are two nodes behind LB :P

Dec 8 2022, 2:09 PM · Bug Report

kloczek added a comment to T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config.

Just checked those two commits and I see in autoconf output:

checking for gpg-error-config... no
checking for gpgrt-config... /usr/bin/gpgrt-config
configure: Use gpgrt-config with /usr/lib64 as gpg-error-config
checking for GPG Error - version >= 1.36... yes (1.46-unknown)
configure: Use gpgrt-config as libassuan-config
checking for LIBASSUAN - version >= 2.4.2... yes (2.5.5-unknown)
checking LIBASSUAN API version... okay

So looks like there is more use of *-config scripts and those detections takes longer time so it would be good to move that as well to pkgconfig.

Dec 8 2022, 2:08 PM · Bug Report

kloczek added a comment to T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config.

I cannot find the commit which fixes this issue.

Dec 8 2022, 12:55 PM · Bug Report

Dec 7 2022

kloczek renamed T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config from 1.18.0: gpgme pythpn bindings fails because it ties to use gpg-error-config to 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config.

Dec 7 2022, 9:45 PM · Bug Report

kloczek renamed T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config from 1.18.0: gpgme pythpn bindings fails because it teies to use gpg-error-config to 1.18.0: gpgme pythpn bindings fails because it ties to use gpg-error-config.

Dec 7 2022, 9:44 PM · Bug Report

kloczek created T6306: 1.18.0: gpgme pythpn bindings fails because it tries to use gpg-error-config.

Dec 7 2022, 9:44 PM · Bug Report

Sep 21 2021

kloczek added a comment to T5611: 2.3.2: test suite is failing.

I think that scenario with TPM emulation would be more generic.
What needs to be done to have TPM emulation? Can you point on some doc about that?

Sep 21 2021, 3:19 PM · Support, gnupg (gpg23)

kloczek created T5611: 2.3.2: test suite is failing.

Sep 21 2021, 1:01 PM · Support, gnupg (gpg23)

kloczek added a comment to T5606: 2.3.2: compile and link time warnings.

LTO warnings are trashing LTO optimised binaries and that is definitelly gnupg code issiues.
Just check each two places where rowtines are defined and declared in header files.

Sep 21 2021, 12:37 PM · Bug Report

Sep 19 2021

kloczek created T5606: 2.3.2: compile and link time warnings.

Sep 19 2021, 1:34 PM · Bug Report

Jun 28 2021

kloczek added a comment to T4416: gnupg isn't LTO ready.

test-stubs.c:374:1: note: 'show_photos' was previously declared here
keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch]
   35 | struct keyserver_spec *parse_keyserver_uri (const char *string,
      |                        ^
test-stubs.c:356:1: note: type mismatch in parameter 3
  356 | parse_keyserver_uri (const char *uri, int require_scheme,
      | ^
test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here
keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch]
   60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name,
      |     ^
test-stubs.c:243:1: note: type mismatch in parameter 2
  243 | keyserver_import_ldap (const char *name)
      | ^
test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here
keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch]
   57 | int keyserver_import_name (ctrl_t ctrl,
      |     ^
test-stubs.c:224:1: note: type mismatch in parameter 3
  224 | keyserver_import_name (const char *name,struct keyserver_spec *spec)
      | ^
test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here
keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch]
   50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode,
      |     ^
test-stubs.c:205:1: note: type mismatch in parameter 2
  205 | keyserver_import_cert (const char *name)
      | ^
test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here
keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch]
   44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid,
      |     ^
test-stubs.c:184:1: note: type mismatch in parameter 3
  184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags)
      | ^
test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here
photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch]
   31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count,
      |      ^
test-stubs.c:374:1: note: type mismatch in parameter 2
  374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk)
      | ^
test-stubs.c:374:1: note: 'show_photos' was previously declared here
keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch]
   35 | struct keyserver_spec *parse_keyserver_uri (const char *string,
      |                        ^
test-stubs.c:356:1: note: type mismatch in parameter 3
  356 | parse_keyserver_uri (const char *uri, int require_scheme,
      | ^
test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here
keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch]
   60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name,
      |     ^
test-stubs.c:243:1: note: type mismatch in parameter 2
  243 | keyserver_import_ldap (const char *name)
      | ^
test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here
keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch]
   57 | int keyserver_import_name (ctrl_t ctrl,
      |     ^
test-stubs.c:224:1: note: type mismatch in parameter 3
  224 | keyserver_import_name (const char *name,struct keyserver_spec *spec)
      | ^
test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here
keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch]
   50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode,
      |     ^
test-stubs.c:205:1: note: type mismatch in parameter 2
  205 | keyserver_import_cert (const char *name)
      | ^
test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here
keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch]
   44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid,
      |     ^
test-stubs.c:184:1: note: type mismatch in parameter 3
  184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags)
      | ^
test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here
photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch]
   31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count,
      |      ^
test-stubs.c:374:1: note: type mismatch in parameter 2
  374 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk)
      | ^
test-stubs.c:374:1: note: 'show_photos' was previously declared here
keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch]
   35 | struct keyserver_spec *parse_keyserver_uri (const char *string,
      |                        ^
test-stubs.c:356:1: note: type mismatch in parameter 3
  356 | parse_keyserver_uri (const char *uri, int require_scheme,
      | ^
test-stubs.c:356:1: note: 'parse_keyserver_uri' was previously declared here
keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch]
   60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name,
      |     ^
test-stubs.c:243:1: note: type mismatch in parameter 2
  243 | keyserver_import_ldap (const char *name)
      | ^
test-stubs.c:243:1: note: 'keyserver_import_ldap' was previously declared here
keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch]
   57 | int keyserver_import_name (ctrl_t ctrl,
      |     ^
test-stubs.c:224:1: note: type mismatch in parameter 3
  224 | keyserver_import_name (const char *name,struct keyserver_spec *spec)
      | ^
test-stubs.c:224:1: note: 'keyserver_import_name' was previously declared here
keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch]
   50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode,
      |     ^
test-stubs.c:205:1: note: type mismatch in parameter 2
  205 | keyserver_import_cert (const char *name)
      | ^
test-stubs.c:205:1: note: 'keyserver_import_cert' was previously declared here
keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch]
   44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid,
      |     ^
test-stubs.c:184:1: note: type mismatch in parameter 3
  184 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags)
      | ^
test-stubs.c:184:1: note: 'keyserver_import_keyid' was previously declared here
photoid.h:31:6: warning: type of 'show_photos' does not match original declaration [-Wlto-type-mismatch]
   31 | void show_photos (ctrl_t ctrl, const struct user_attribute *attrs, int count,
      |      ^
gpgv.c:617:1: note: type mismatch in parameter 2
  617 | show_photos (const struct user_attribute *attrs, int count, PKT_public_key *pk)
      | ^
gpgv.c:617:1: note: 'show_photos' was previously declared here
keyserver-internal.h:35:24: warning: type of 'parse_keyserver_uri' does not match original declaration [-Wlto-type-mismatch]
   35 | struct keyserver_spec *parse_keyserver_uri (const char *string,
      |                        ^
gpgv.c:599:1: note: type mismatch in parameter 3
  599 | parse_keyserver_uri (const char *uri, int require_scheme,
      | ^
gpgv.c:599:1: note: 'parse_keyserver_uri' was previously declared here
keyserver-internal.h:60:5: warning: type of 'keyserver_import_ldap' does not match original declaration [-Wlto-type-mismatch]
   60 | int keyserver_import_ldap (ctrl_t ctrl, const char *name,
      |     ^
gpgv.c:485:1: note: type mismatch in parameter 2
  485 | keyserver_import_ldap (const char *name)
      | ^
gpgv.c:485:1: note: 'keyserver_import_ldap' was previously declared here
keyserver-internal.h:57:5: warning: type of 'keyserver_import_name' does not match original declaration [-Wlto-type-mismatch]
   57 | int keyserver_import_name (ctrl_t ctrl,
      |     ^
gpgv.c:466:1: note: type mismatch in parameter 3
  466 | keyserver_import_name (const char *name,struct keyserver_spec *spec)
      | ^
gpgv.c:466:1: note: 'keyserver_import_name' was previously declared here
keyserver-internal.h:50:5: warning: type of 'keyserver_import_cert' does not match original declaration [-Wlto-type-mismatch]
   50 | int keyserver_import_cert (ctrl_t ctrl, const char *name, int dane_mode,
      |     ^
gpgv.c:447:1: note: type mismatch in parameter 2
  447 | keyserver_import_cert (const char *name)
      | ^
gpgv.c:447:1: note: 'keyserver_import_cert' was previously declared here
keyserver-internal.h:44:5: warning: type of 'keyserver_import_keyid' does not match original declaration [-Wlto-type-mismatch]
   44 | int keyserver_import_keyid (ctrl_t ctrl, u32 *keyid,
      |     ^
gpgv.c:426:1: note: type mismatch in parameter 3
  426 | keyserver_import_keyid (u32 *keyid, void *dummy, unsigned int flags)
      | ^
gpgv.c:426:1: note: 'keyserver_import_keyid' was previously declared here
certchain.c:2123:1: note: in a call to function 'gpgsm_validate_chain'
 2123 | gpgsm_validate_chain (ctrl_t ctrl, ksba_cert_t cert, ksba_isotime_t checktime,
      | ^
cvt-openpgp.h:27:13: warning: type of 'convert_from_openpgp_native' does not match original declaration [-Wlto-type-mismatch]
   27 | gpg_error_t convert_from_openpgp_native (ctrl_t ctrl,
      |             ^
t-protect.c:344:1: note: type mismatch in parameter 4
  344 | convert_from_openpgp_native (gcry_sexp_t s_pgp, const char *passphrase,
      | ^
t-protect.c:344:1: note: 'convert_from_openpgp_native' was previously declared here

Jun 28 2021, 2:00 AM

kloczek added a comment to T4416: gnupg isn't LTO ready.

In this case it is not about don't consult the return code or casting sometning byt messy declaration in header files and .c files.
Please have look closer one more time on [-Wlto-type-mismatch] warnings.

Jun 28 2021, 1:55 AM

Jul 16 2020

kloczek added a comment to T4854: gpgme 1.13.1: test suite is failing.

Today when I've been trying with -j48 test suite was locked and was not able to finish.
When I've presses ctrol-c I found:

PASS: t-eventloop
Decrypt B 0
Encrypt A 0
Decrypt B 1
Encrypt A 1
Decrypt B 2
Encrypt A 2
Decrypt B 3
Encrypt A 3
Decrypt B 4
Decrypt B 5
Encrypt A 4
Decrypt B 6
Encrypt A 5
Decrypt B 7
Encrypt A 6
Decrypt B 8
Encrypt A 7
Decrypt B 9
Encrypt A 8
Decrypt B 10
Encrypt A 9
Decrypt B 11
Encrypt A 10
Decrypt B 12
Encrypt A 11
Decrypt B 13
Encrypt A 12
Decrypt B 14
Encrypt A 13
Decrypt B 15
Encrypt A 14
Decrypt B 16
Decrypt B 17
Encrypt A 15
Decrypt B 18
Encrypt A 16
Decrypt B 19
Encrypt A 17
Encrypt A 18
Encrypt A 19
PASS: t-thread1
make[4]: *** [Makefile:882: check-TESTS] Interrupt
make[4]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/tests/gpg'
[tkloczko@barrel SPECS]$ make[3]: *** [Makefile:1008: check-am] Interrupt
make[2]: *** [Makefile:1010: check] Interrupt
make[1]: *** [Makefile:736: check-recursive] Interrupt
make: *** [Makefile:535: check-recursive] Interrupt
^C

Jul 16 2020, 12:55 AM · gpgme, Bug Report

kloczek added a comment to T4854: gpgme 1.13.1: test suite is failing.

+ GPGME_DEBUG=8:gpgme.trc
+ /usr/bin/make -O -j1 V=1 VERBOSE=1 check
Making check in src
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/src'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/src'
Making check in tests
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/tests'
Making check in gpg
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/tests/gpg'
/usr/bin/make  check-am
make[3]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/tests/gpg'
/usr/bin/make  check-TESTS
make[4]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gpgme-1.13.1/tests/gpg'
gpg-agent already running
PASS: initial.test
-----BEGIN PGP MESSAGE-----

Jul 16 2020, 12:52 AM · gpgme, Bug Report

Jul 15 2020

kloczek added a comment to T4854: gpgme 1.13.1: test suite is failing.

In T4854#135871, @werner wrote:

Sorry, I can't replicate this

Jul 15 2020, 5:23 PM · gpgme, Bug Report

Feb 25 2020

kloczek added a comment to T4854: gpgme 1.13.1: test suite is failing.

Latest one (gnupg 2.2.19)

Feb 25 2020, 10:37 PM · gpgme, Bug Report

kloczek updated the task description for T4854: gpgme 1.13.1: test suite is failing.

Feb 25 2020, 2:53 PM · gpgme, Bug Report

kloczek created T4854: gpgme 1.13.1: test suite is failing.

Feb 25 2020, 2:52 PM · gpgme, Bug Report

kloczek added a comment to T4853: libgpg-error: after regenerate ac/am/lt files and build reported version is 1.37-unknown.

Sorry but that really strange.
I need to regenerate those files.
Could you please describe what needs to be done to have proper version?

Feb 25 2020, 1:51 PM · Bug Report

kloczek created T4853: libgpg-error: after regenerate ac/am/lt files and build reported version is 1.37-unknown.

Feb 25 2020, 3:01 AM · Bug Report

Aug 26 2019

kloczek added a comment to T4685: Any plans to make new release?.

Please do not force me subscribe to yet another mailing list to see the answer.
So do you have any plans to make new release? :)

Aug 26 2019, 9:58 AM · Bug Report

Aug 24 2019

kloczek created T4685: Any plans to make new release?.

Aug 24 2019, 6:24 PM · Bug Report

Jul 2 2019

kloczek added a comment to T4602: 2.2.16: test suite fails.

I cannot do that because all listed above packages are my own products.
Fedora is not execution test suites in more than 90% of all packages so they are not aware of most of the issues exposed by test suites.
Please focus on possible causes of above tests.
I'm opened on any suggestions to make additional diagnostics.

Jul 2 2019, 4:02 PM · Fedora, gnupg, Bug Report

kloczek added a comment to T4602: 2.2.16: test suite fails.

[tkloczko@barrel SPECS]$ uname -a
Linux barrel 5.1.5-300.fc30.x86_64 #1 SMP Sat May 25 18:00:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
[tkloczko@barrel SPECS]$ rpm -q libassuan-devel libcurl-devel libgcrypt-devel libgpg-error-devel libksba-devel libusb-devel npth-devel openldap-devel pcsc-lite-libs gnutls-devel sqlite-devel
libassuan-devel-2.5.3-2.1.fc31.x86_64
libcurl-devel-7.65.1-2.fc31.x86_64
libgcrypt-devel-1.8.4-4.1.fc31.x86_64
libgpg-error-devel-1.36-2.fc31.x86_64
libksba-devel-1.3.5-10.1.fc31.x86_64
libusb-devel-0.1.5-14.fc30.x86_64
npth-devel-1.6-3.fc31.x86_64
openldap-devel-2.4.47-2.2.fc31.x86_64
pcsc-lite-libs-1.8.25-2.1.fc31.x86_64
gnutls-devel-3.6.8-2.fc31.x86_64
sqlite-devel-3.28.0-2.fc31.x86_64

Still about half of the packages are from Fedora rawhide but rest are mine.
Just checked and the test suite fails exactly the same way even started without palatalisation.

Jul 2 2019, 3:11 PM · Fedora, gnupg, Bug Report

kloczek created T4602: 2.2.16: test suite fails.

Jul 2 2019, 9:00 AM · Fedora, gnupg, Bug Report

Apr 7 2019

kloczek added a comment to T4415: Does not build using gcc 9.

Which one version gcc 9 you've been using?
May I see gcc -v ?

Apr 7 2019, 8:46 AM · Info Needed, toolchain, Bug Report

Apr 6 2019

kloczek added a comment to T4415: Does not build using gcc 9.

BTW: fedora corp provides already free access to build envs with gcc 9 which can be easily integrated with CIs.

Apr 6 2019, 8:49 AM · Info Needed, toolchain, Bug Report

kloczek added a comment to T4415: Does not build using gcc 9.

What you mean " it is not reproducible for u"?
Did you try to use gcc 9 and you had no problems compiling gnupg or you don't have access to build env with gcc 9?
Try to google to "gcc 9 pragma" and you will find several discussions and patches done by people fixing similar issues.

Apr 6 2019, 8:48 AM · Info Needed, toolchain, Bug Report