Page MenuHome GnuPG

qyliss (Alyssa Ross)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 17 2019, 10:09 PM (284 w, 4 d)
Availability
Available

Recent Activity

Jun 30 2024

qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.

Can this be accepted? Since GPGME is doing a direct syscall, rather than going through the libc wrapper, there's no need for it to use libc-specific types. It makes more sense (and is more portable) to use the sized types equivalent to the definition that the kernel uses.

Jun 30 2024, 11:12 AM · gpgme

May 10 2024

qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.

Ah, I see what's up with the man page. It's documenting the Glibc getdents64() wrapper interface, so that's why it uses the Glibc types. But gpgme isn't using that wrapper, it's doing the syscall directly, so it should use the types the kernel uses, which as you've noticed are just generic unsigned and signed 64-bit integers, matching what my patch does.

May 10 2024, 10:48 AM · gpgme

May 8 2024

qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.

$ man getdents64

getdents64()
    The  original  Linux getdents() system call did not handle large filesystems and large file offsets.  Consequently, Linux 2.4
    added getdents64(), with wider types for the d_ino and d_off fields.  In addition, getdents64() supports an  explicit  d_type
    field.

    The  getdents64()  system call is like getdents(), except that its second argument is a pointer to a buffer containing struc‐
    tures of the following type:

        struct linux_dirent64 {
            ino64_t        d_ino;    /* 64-bit inode number */
            off64_t        d_off;    /* 64-bit offset to next structure */
            unsigned short d_reclen; /* Size of this dirent */
            unsigned char  d_type;   /* File type */
            char           d_name[]; /* Filename (null-terminated) */
        };
May 8 2024, 1:19 PM · gpgme
qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.
In D600#6445, @gniibe wrote:

If it is intentional change by musl (requiring some changes by an application), we can use __ino64_t_defined and __off64_t_defined macro to see if those types are defined or not.

May 8 2024, 9:45 AM · gpgme

May 6 2024

qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.

off64_t mat not the same as int64_t

May 6 2024, 3:42 PM · gpgme
qyliss added a comment to D600: posix: don't use LFS64 types in struct linux_dirent64.
In D600#6438, @werner wrote:

This breaks existing 32 bit systems with the 64 bit types.

May 6 2024, 10:37 AM · gpgme

May 3 2024

qyliss requested review of D600: posix: don't use LFS64 types in struct linux_dirent64.
May 3 2024, 1:46 PM · gpgme

Feb 18 2022

qyliss requested review of D549: qt: make the pin entry dialog float again.
Feb 18 2022, 9:57 PM