Home GnuPG

If the Script-and-Regex linter captures no "line" text, treat the message as…
05c12eb9d9cbUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

If the Script-and-Regex linter captures no "line" text, treat the message as affecting the entire file

Summary: Fixes T10124.

Test Plan:
Added this "linter" to .arclint:

"thing": {
  "type": "script-and-regex",
  "script-and-regex.script": "echo every file is very bad #",
  "script-and-regex.regex": "/^(?P<message>.*)/"
}

...to produce this diff. Also made a variant of it which matches lines to make sure that still works.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10124

Differential Revision: https://secure.phabricator.com/D15000

Details

Provenance
epriestley <git@epriestley.com>Authored on Jan 12 2016, 2:18 AM
Parents
rARCaeb374b33348: Fix cpplint message regex
Branches
Unknown
Tags
Unknown

Event Timeline