Home GnuPG

Fix two minor issues with "arc download"
27b51e619237Unpublished

Unpublished Commit ยท Learn More

Publishing Disabled: All publishing is disabled for this repository.

Description

Fix two minor issues with "arc download"

Summary:
Ref T12651. Ran into these during D17799:

  • Use getStatusCode() to put the actual status code into the message.
  • If we fail but wrote an empty file to reserve the filename, clean it up.

Test Plan:

  • Faked the error, phlog()'d the exception.
  • Saw sensible exception message.
  • Saw empty file get cleaned up.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12651

Differential Revision: https://secure.phabricator.com/D17800

Details

Provenance
epriestley <git@epriestley.com>Authored on Apr 28 2017, 1:17 AM
marcusPushed on May 11 2017, 7:34 PM
Parents
rARC5d0f5afca8cd: Add ArcanistRaggedClassTreeEdgeXHPASTLinterRule to Phutil linter map
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC27b51e619237: Fix two minor issues with "arc download" (authored by epriestley <git@epriestley.com>).Apr 28 2017, 4:45 PM