Home GnuPG

Improve linter handling of short array syntax
27ec3a2e34aaUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improve linter handling of short array syntax

Summary: Currently, linting PHP short array syntax (i.e. [...]) throws an exception ("Expected open parentheses"). This diff relaxes some restrictions which prevent short array syntax from linting with ArcanistParenthesesSpacingXHPASTLinterRule.

Test Plan: Modified test cases.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: agenticarus, Korvin

Differential Revision: https://secure.phabricator.com/D13895

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 19 2015, 7:35 AM
Joshua Spence <josh@freelancer.com>Committed on Aug 19 2015, 7:35 AM
Parents
rARC4404e66735c4: Improve the "inline HTML" linter rule
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC27ec3a2e34aa: Improve linter handling of short array syntax (authored by Joshua Spence <josh@joshuaspence.com>).Aug 19 2015, 7:35 AM