Home GnuPG

Add a linter rule to determine whether a class should be marked as `abstract`
37571d883952Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule to determine whether a class should be marked as abstract

Summary:
A class containing abstract methods must itself be marked as abstract.

PHP Fatal error:  Class X contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (X::Y) in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 5

Test Plan: Added unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14559

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Nov 23 2015, 10:18 PM
Parents
rARC20e99acf0ad1: Add a linter rule for `abstract private` methods
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC37571d883952: Add a linter rule to determine whether a class should be marked as `abstract` (authored by Joshua Spence <josh@freelancer.com>).Nov 23 2015, 10:18 PM