Home GnuPG

Make callsigns optional in arcanist
3d7ac867f538Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Make callsigns optional in arcanist

Summary:
Remove couple of references to callsigns:

  • arc which now prints repository name
  • getShouldAmend() can now use new format of commit name

a quick git-grep looks like the remaining references are all about repository.callsign config.

Ref T4245

Test Plan:

  • arc which on a repository with no callsign
  • trigger requireCleanWorkingCopy(), see both "Do you want to amend this change" and "Do you want to create a new commit" prompts.
  • fire this diff with new code.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D15472

Details

Provenance
Aviv Eyal <avivey@gmail.com>Authored on Mar 15 2016, 4:58 AM
avivey <autocommitter@example.com>Committed on Mar 15 2016, 4:58 AM
Parents
rARCccbaee585e1a: When `arc` pushes to the staging area, tell Phabricator what we did
Branches
Unknown
Tags
Unknown

Event Timeline

avivey <autocommitter@example.com> committed rARC3d7ac867f538: Make callsigns optional in arcanist (authored by Aviv Eyal <avivey@gmail.com>).Mar 15 2016, 4:58 AM