Home GnuPG

Improve useless overriding method linter rule
6c759ae34396Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Improve useless overriding method linter rule

Summary:
Improve ArcanistUselessOverridingMethodXHPASTLinterRule by allowing overriding methods which set default values. For example, the following scenario is perfectly valid:

class SomeClass {
  public function __construct($x) {}
}

class SomeOtherClass extends Class {
  public function __construct($x = null) {
    parent::__construct($x);
  }
}

Test Plan: Added test case.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13840

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Aug 10 2015, 10:49 PM
Parents
rARCf43b74c6052f: Improve PHP compatibility linter
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARC6c759ae34396: Improve useless overriding method linter rule (authored by Joshua Spence <josh@joshuaspence.com>).Aug 10 2015, 10:49 PM