Home GnuPG

Avoid parsing git "remote show" using "ls-remote"
6ecb3fb87d2bUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Avoid parsing git "remote show" using "ls-remote"

Summary:
Ref T5554. This makes git remote URL detection locale-agnostic.

The previously suggested git config remote.origin.url command does
almost the same, but does not support the URL rewriting features in
git-config (url.<base>.insteadOf).

This one does, although it has the unintuitive behavior of just printing
the passed remote name when the remote does not exist, or even when
called outside a git repo.

Test Plan:

  • Switched to non-english locale in which git has a translation.
  • Ran arc which on the Arcanist repo. It could not determine the remote URI.
  • Applied patch, arc which found the URI.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: johnny-bit, Korvin

Maniphest Tasks: T5554

Differential Revision: https://secure.phabricator.com/D13983

Details

Provenance
Javier Arteaga <code@jbeta.is>Authored on Aug 24 2015, 1:51 PM
epriestley <git@epriestley.com>Committed on Aug 24 2015, 1:51 PM
Parents
rARC9b8c9d280ea4: Exclude variables used in strings inside closures when checking for undeclared…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC6ecb3fb87d2b: Avoid parsing git "remote show" using "ls-remote" (authored by Javier Arteaga <code@jbeta.is>).Aug 24 2015, 1:51 PM