Home GnuPG
Diffusion Arcanist 76ae02325dd3

Fix another edge case for "function call should be type cast" linter rule
76ae02325dd3Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fix another edge case for "function call should be type cast" linter rule

Summary: Fix a minor issue in which changing a function call to a type cast affects the result of an expression.

Test Plan: Added test case.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14623

Details

Provenance
Joshua Spence <josh@freelancer.com>Authored on Dec 2 2015, 4:13 AM
Parents
rARC09052d52470d: Minor fix for typecast linter rule
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rARC76ae02325dd3: Fix another edge case for "function call should be type cast" linter rule (authored by Joshua Spence <josh@freelancer.com>).Dec 2 2015, 4:13 AM

Changes (2)

PathSize
src/
lint/
linter/
xhpast/
rules/
__tests__/
function-call-should-be-type-cast/

rARC76ae02325dd3

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/function-call-should-be-type-cast/binary-expression.lint-test

Loading...