Home GnuPG
Diffusion Arcanist 7d25fcdbdb51

Simplify diff exit code handling.
7d25fcdbdb51Unpublished
Actions

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Simplify diff exit code handling.

Summary:
This fixes T9970 in an alternate manner, with the same effect: the
binary_safe_diff.sh script returns 0 if the diff succeeds, 1 in all
other cases.

Test Plan:
Tested locally with a fixed binary_safe_diff.sh, resulting in this
correct review:

https://reviews.freebsd.org/D4542

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: eadler, Korvin, stevenh

Maniphest Tasks: T9970

Differential Revision: https://secure.phabricator.com/D14759

Details

Provenance
Dimitry Andric <dimitry@andric.com>Authored on Dec 13 2015, 11:35 AM
epriestley <git@epriestley.com>Committed on Dec 13 2015, 11:35 AM
Parents
rARC97056a3b85bb: Preserve the exit code of the diff command in binary_safe_diff.sh
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC7d25fcdbdb51: Simplify diff exit code handling. (authored by Dimitry Andric <dimitry@andric.com>).Dec 13 2015, 11:35 AM

Changes (1)

PathSize
scripts/
repository/

rARC7d25fcdbdb51

View Options

scripts/repository/binary_safe_diff.sh

Loading...