Home GnuPG

Preserve the exit code of the diff command in binary_safe_diff.sh
97056a3b85bbUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Preserve the exit code of the diff command in binary_safe_diff.sh

Summary:
Some versions of Subversion (1.9 in any case, maybe others) will
duplicate diff headers, if the diff command run through --diff-cmd
returns 0.

This lead to T9970, where the addition of a new file with properties
only shows the properties themselves in the review, not the content of
the new file.

Test Plan: This is a trivial change, is a test needed at all?

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: stevenh, Korvin, eadler

Differential Revision: https://secure.phabricator.com/D14755

Details

Provenance
Dimitry Andric <dimitry@andric.com>Authored on Dec 13 2015, 11:21 AM
epriestley <git@epriestley.com>Committed on Dec 13 2015, 11:21 AM
Parents
rARC74c7495b1a92: Clarify that "arc land" means it is merging changes, not branch refences
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rARC97056a3b85bb: Preserve the exit code of the diff command in binary_safe_diff.sh (authored by Dimitry Andric <dimitry@andric.com>).Dec 13 2015, 11:21 AM