Home GnuPG

Add a linter rule for array separators
be428e320700Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Add a linter rule for array separators

Summary:
Adds a rule to ArcanistXHPASTLinter which ensures that:

  1. Single-lined arrays do not contain an unnecessary trailing comma separator after the final array value.
  2. Multi-lined arrays do contain a trailing comma seperator after the final value value.

Depends on D10534.

Test Plan: Wrote and executed unit tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10535

Details

Provenance
Joshua Spence <josh@joshuaspence.com>Authored on Sep 24 2014, 11:38 PM
Parents
rARC13492c8043a4: Fix a fatal error in `ArcanistXHPASTLinter`
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rARCbe428e320700: Add a linter rule for array separators (authored by Joshua Spence <josh@joshuaspence.com>).Sep 24 2014, 11:40 PM