Home GnuPG

Correct checks for ecc secret key
10dfa41b43a9Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Correct checks for ecc secret key

* cipher/ecc.c (check_secret_key): replace wrong comparison of Q and
sk->Q points with correct one.

Currently check_secret_keys compares pointers to coordinates of Q
(calculated) and sk->Q (provided) points. Instead it should convert them
to affine representations and use mpi_cmp to compare coordinates.

This has an implication that keys that were (erroneously) verified as
valid could now become invalid.

  • Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>

Details

Provenance
lumagAuthored on Jul 31 2013, 3:20 PM
wernerCommitted on Jul 31 2013, 5:47 PM
Parents
rC43320961a875: sexp: Allow white space anywhere in a hex format.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rC10dfa41b43a9: Correct checks for ecc secret key (authored by Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>).Jul 31 2013, 5:47 PM