Fix buggy RC4 AMD64 assembly and add test to notice similar issues
124dfce7c5a2Unpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fix buggy RC4 AMD64 assembly and add test to notice similar issues

* cipher/arcfour-amd64.S (_gcry_arcfour_amd64): Fix swapped store of
'x' and 'y'.
* tests/basic.c (get_algo_mode_blklen): New.
(check_one_cipher_core): Add new tests for split buffer input on
encryption and decryption.

Reported-by: Dima Kukulniak <dima.ky@gmail.com>
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@iki.fi>

Details

Provenance

jukivili

Authored on Apr 30 2015, 3:57 PM

Parents

rCf88266c0f868: Disallow compiler from generating SSE instructions in mixed C+asm source

Branches

Unknown

Tags

Unknown

Event Timeline

Jussi Kivilinna <jussi.kivilinna@iki.fi> committed rC124dfce7c5a2: Fix buggy RC4 AMD64 assembly and add test to notice similar issues (authored by Jussi Kivilinna <jussi.kivilinna@iki.fi>).Apr 30 2015, 3:57 PM

Changes (2)

Path

Size

cipher/

arcfour-amd64.S

tests/

basic.c

rC124dfce7c5a2

View Options

cipher/arcfour-amd64.S