Home GnuPG
Diffusion libgcrypt 8eab66ad6852

Fix alignment problem in serpent.c.
8eab66ad6852Unpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fix alignment problem in serpent.c.

* cipher/serpent.c (serpent_key_prepare): Fix misaligned access.
(serpent_setkey): Likewise.
(serpent_encrypt_internal): Likewise.
(serpent_decrypt_internal): Likewise.
(serpent_encrypt): Don't put an alignment-increasing cast.
(serpent_decrypt): Likewise.
(serpent_test): Likewise.

This is a port of the fix for the Libgcrypt code in GRUB:

http://bzr.savannah.gnu.org/lh/grub/trunk/grub/revision/3685

GRUB is FSF copyrighted and thus we can use this code without a DCO.

Note that the above fix was not correct and failed the selftests, thus
I fixed this fix.

  • GnuPG-bug-id: T1384
  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
Vladimir Serbinenko <phcoder@gmail.com>Authored on Apr 18 2013, 1:22 PM
• wernerCommitted on Apr 18 2013, 1:25 PM
Parents
rCcc2f85116226: Fix multiply by zero in gcry_mpi_ec_mul.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rC8eab66ad6852: Fix alignment problem in serpent.c. (authored by Vladimir Serbinenko <phcoder@gmail.com>).Apr 18 2013, 1:25 PM

Changes (2)

PathSize
cipher/

rC8eab66ad6852

View Options

AUTHORS

Loading...
View Options

cipher/serpent.c

Loading...