Home GnuPG

cipher: Avoid signed divisions in idea.c
e241dde14204Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

cipher: Avoid signed divisions in idea.c

* cipher/idea.c (mul_inv): Use unsigned division.
Hello, all. While compiling in an environment with only libgcc
subset for ARM, I found out that idea.c uses signed divisions:
Reading the code this seems to be unintended. Inlined patch replaces
them with more appropriate unsigned division.
  • Reported-by: Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>
  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Nov 8 2013, 5:21 PM
Parents
rC9f63c0f7a3b2: ecc: Implement the "nocomp" flag for key generation.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rCe241dde14204: cipher: Avoid signed divisions in idea.c (authored by Werner Koch <wk@gnupg.org>).Nov 8 2013, 5:21 PM