Home GnuPG
Diffusion GnuPG 044e5a3c3801

scd: Detect external interference when PCSC_SHARED.
Concern Raised044e5a3c3801
Actions

Description

scd: Detect external interference when PCSC_SHARED.

* scd/app-common.h (check_aid): New method.
* scd/app-openpgp.c (do_check_aid): New.
* scd/app-piv.c (do_check_aid): New.
* scd/app.c (check_external_interference): New.
(maybe_switch_app): Check interference to determine switching is
needed.
  • GnuPG-bug-id: T5484
  • Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

Details

Auditors
Sanmilie
Provenance
• gniibeAuthored on Jul 6 2021, 7:52 AM
Parents
rG5f78ae696c10: artwork: Explain the license for the logo
Branches
Unknown
Tags
Unknown
Tasks
T5484: SCDaemon Not reselect applet and reauthenticate when the card send Security Not Sastisfied

Event Timeline

• gniibe committed rG044e5a3c3801: scd: Detect external interference when PCSC_SHARED. (authored by • gniibe).Jul 6 2021, 7:52 AM
• gniibe added a task: T5484: SCDaemon Not reselect applet and reauthenticate when the card send Security Not Sastisfied.Jul 6 2021, 7:57 AM
Sanmilie raised a concern with this commit.Aug 24 2021, 8:40 PM
Sanmilie added a subscriber: Sanmilie.

Line 1454 : if (!opt.pcsc_shared || app->card->cardtype != CARDTYPE_YUBIKEY)
need to remove || app->card->cardtype != CARDTYPE_YUBIKEY

Need the interferecne check always when the PCSC_Shared is enabled. not only for yubikey
Line 1454 : if (!opt.pcsc_shared)

This commit now has outstanding concerns.Aug 24 2021, 8:40 PM
• gniibe added a comment.Aug 26 2021, 6:55 AM

I understand your problem.

The intention of the condition is to minimize the check.

IIUC about your use case, it would be good to add CARDTYPE_SOMETHING and add that one to the condition.

Please open new ticket for this.

Changes (4)

PathSize
scd/

rG044e5a3c3801

View Options

scd/app-common.h

Loading...
View Options

scd/app-openpgp.c

Loading...
View Options

scd/app-piv.c

Loading...
View Options

scd/app.c

Loading...