Home GnuPG
Diffusion GnuPG 04b56eff118e

dirmngr: hkp: Avoid potential race condition when some hosts die.


dirmngr: hkp: Avoid potential race condition when some hosts die.

* dirmngr/ks-engine-hkp.c (select_random_host): Use atomic pass
through the host table instead of risking out-of-bounds write.

Multiple threads may write to hosttable[x]->dead while
select_random_host() is running. For example, a housekeeping thread
might clear the ->dead bit on some entries, or another connection to
dirmngr might manually mark a host as alive.

If one or more hosts are resurrected between the two loops over a
given table in select_random_host(), then the allocation of tbl might
not be large enough, resulting in a write past the end of tbl on the
second loop.

This change collapses the two loops into a single loop to avoid this
discrepancy: each host's "dead" bit is now only checked once.

As Werner points out, this isn't currently strictly necessary, since
npth will not switch threads unless a blocking system call is made,
and no blocking system call is made in these two loops.

However, in a subsequent change in this series, we will call a
function in this loop, and that function may sometimes write(2), or
call other functions, which may themselves block. Keeping this as a
single-pass loop avoids the need to keep track of what might block and
what might not.

  • GnuPG-bug-id: T2836
  • Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>


dkgAuthored on Oct 29 2016, 7:25 AM
gniibeCommitted on Sep 7 2018, 7:28 AM
rG7c96cc67e108: g10: Fix memory leak.
Reverted By
rG69bab1cba07a: Revert "dirmngr: hkp: Avoid potential race condition when some hosts die."
T2836: dirmngr: wakes up periodically