build: Always use EXTERN_UNLESS_MAIN_MODULE pattern.
21d9bd8b87a9
Actions

Description

build: Always use EXTERN_UNLESS_MAIN_MODULE pattern.

* common/util.h (EXTERN_UNLESS_MAIN_MODULE): Add the definion only
here but now without the Norcroft-C.  Change all other places where it
gets defined.
* common/iobuf.h (iobuf_debug_mode): Declare unconditionally as
extern.
* common/iobuf.c (iobuf_debug_mode): Define it here.
* agent/gpg-agent.c (INCLUDED_BY_MAIN_MODULE): Define here and also in
all main modules of all other programs.
* g10/main.h: Put util.h before the local header files.

This change is required for use with gcc/ld's LTO feature which does
not allow common blocks. Further gcc 10 will make -fno-common the
default and thus this chnage is always needed. What a pitty.

build: Always use EXTERN_UNLESS_MAIN_MODULE pattern.21d9bd8b87a9Actions

Description

Details

Event Timeline

Changes (28)

rG21d9bd8b87a9

agent/agent.h

agent/gpg-agent.c

agent/preset-passphrase.c

agent/protect-tool.c

agent/t-protect.c

common/iobuf.c

common/iobuf.h

common/util.h

dirmngr/dirmngr.c

dirmngr/dirmngr.h

g10/gpgcompose.c

g10/main.h

g10/options.h

g10/test.c

g13/g13-common.h

g13/g13-syshelp.c

g13/g13.c

scd/scdaemon.c

scd/scdaemon.h

sm/gpgsm.c

sm/gpgsm.h

tools/gpg-wks-client.c

tools/gpg-wks-server.c

tools/gpg-wks.h

tools/gpgconf.c

tools/gpgconf.h

tools/gpgtar.c

tools/gpgtar.h

build: Always use EXTERN_UNLESS_MAIN_MODULE pattern.
21d9bd8b87a9
Actions