Home GnuPG
Diffusion GnuPG 55c9212a2338

common: Clarify use of vars in buffer copy code.
55c9212a2338Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

common: Clarify use of vars in buffer copy code.

* common/exectool.c (my_error_from_errno): New.
(copy_buffer_do_copy): Use separate vars for errno values and
gpg-error values for clarity.  s/assert/log_assert/.
(copy_buffer_flush): Ditto.
(gnupg_exec_tool_stream): Use gpg_err_code when testing.

NB: It is surprising that es_write seems not to set ERRNO but only
returns the ERRNO value. Need to check whether this is really the
case.

  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Jan 19 2017, 9:57 AM
Parents
rG367349b4dcc9: dirmngr: Add setup of CA for NTBTLS.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rG55c9212a2338: common: Clarify use of vars in buffer copy code. (authored by Werner Koch <wk@gnupg.org>).Jan 19 2017, 9:59 AM