Home GnuPG
Diffusion GnuPG 685b782a18ad

dirmngr: Cleanup zombies and fix hang on shutdown.
685b782a18adUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

dirmngr: Cleanup zombies and fix hang on shutdown.

* dirmngr/ldap-wrapper.c (ldap_wrapper_thread): Move nfds computation
into the loop.  Check the queue also on timeout.  Close log_fd and
reader context on EOF or error.

The major bug here was that on an EOF of the log fd the log fd was not
closed and thus the final queue item removal could not work. Checking
the queue on a timeout is not really necessary but it help in case
there is a race condition lingering.

  • GnuPG-bug-id: T1838, T1978
  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Jun 16 2015, 6:08 PM
Parents
rGeb4d33cba9cd: dirmngr: Add missing cast for use of pid_t in printf.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rG685b782a18ad: dirmngr: Cleanup zombies and fix hang on shutdown. (authored by Werner Koch <wk@gnupg.org>).Jun 16 2015, 6:11 PM
werner mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:07 PM
werner mentioned this in Unknown Object (Maniphest Task).
werner mentioned this in Unknown Object (Maniphest Task).Mar 27 2017, 5:30 PM
werner mentioned this in Unknown Object (Maniphest Task).