Home GnuPG
Diffusion GnuPG 693838f0125d

gpg: Fix buglet in the check_all_keysigs function.
693838f0125dUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

gpg: Fix buglet in the check_all_keysigs function.

* g10/keyedit.c (sig_comparison): Actually compare the pubkey
algorithms.

This fixes two bugs: The first was a typo which led to us comparing A
with A. The second problem was the use of an assert at a place where
this can't be asserted: Two signature may have different algorithms;
they won't verify but after all it is about corrupted signatures.

  • Reported-by: Guilhem Moulin <guilhem@fripost.org>
  • GnuPG-bug-id: T2236
  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on May 9 2016, 9:07 PM
Parents
rGd33b35f7481c: gpg: Request a "save" after cmd "check" fixed something.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rG693838f0125d: gpg: Fix buglet in the check_all_keysigs function. (authored by Werner Koch <wk@gnupg.org>).May 9 2016, 9:16 PM