Home GnuPG
Diffusion GnuPG 9f5578c29adb

agent: Fix UPDATESTARTUPTTY for ssh.
9f5578c29adbUnpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

agent: Fix UPDATESTARTUPTTY for ssh.

* agent/command-ssh.c (setup_ssh_env): Fix env setting.

gniibe reported this to gnupg-devel on 2012-07-04:

[...]
(2) UPDATESTARTUPTTY doesn't work to switch TTY for pinentry for
    SSH.

[...]

Current implementation:

    In the function start_command_handler_ssh, the logic puts
    priority on ctrl->session_env which is initialized by
    agent_init_default_ctrl.  There are always GPG_TTY and TERM
    defined, because lines around 968 in gpg-agent.c, it says:

	/* Make sure that we have a default ttyname. */

    While UPDATESTARTUPTTY updates opt.startup_env, it doesn't
    affect at all.

Here is a patch to point the issue.  Tested and works for me.
  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Aug 19 2013, 11:44 AM
Parents
rG0c5d3da96a72: tests: Make sure not to create files outside the build directory.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rG9f5578c29adb: agent: Fix UPDATESTARTUPTTY for ssh. (authored by Werner Koch <wk@gnupg.org>).Aug 19 2013, 11:44 AM