Home GnuPG

Don't call QtPass::setup() from QtPass class constructor

Description

Don't call QtPass::setup() from QtPass class constructor

QtPass::setup() cannot be called from this class constructor as it
possibly calls back MainWindow::config() method.
QtPass constructor is in turn called from the MainWindow one so the
MainWindow object might not be fully constructed yet.

It looks like this was introduced in commit bc19f9eeb5bbcd.

Rename QtPass::setup() to QtPass::init() and call it explicitly at the end
of the MainWindow constructor.

Should fix https://github.com/IJHack/QtPass/issues/466, but the whole thing
really needs a refactoring to establish a clear QtPass -> MainWindow (or
MainWindow -> QtPass) relationship and to make sure there aren't any
circular dependencies there (and other similar bugs).

Details

Provenance
mssAuthored on Oct 2 2019, 10:45 PM
Parents
rGPGPASSfc2aed35a9ea: Make QtPass class constructor take a MainWindow object directly
Branches
Unknown
Tags
Unknown

Event Timeline