dirmngr,gpgsm: Return NULL on fail
abd5f6752d69Unpublished
Actions

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

dirmngr,gpgsm: Return NULL on fail

* dirmngr/ldapserver.c (ldapserver_parse_one): Set SERVER to NULL.
* sm/gpgsm.c (parse_keyserver_line): Ditto.

"If something inside the ldapserver_parse_one function failed,
 'server' would be freed, then returned, leading to a
 use-after-free.  This code is likely copied from sm/gpgsm.c, which
 was also susceptible to this bug."

Reported-by: Joshua Rogers <git@internot.info>
Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance

• werner

Authored on Dec 22 2014, 12:16 PM

Parents

rGbdc8efbdd124: scd: ECDH Support.

Branches

Unknown

Tags

Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rGabd5f6752d69: dirmngr,gpgsm: Return NULL on fail (authored by Werner Koch <wk@gnupg.org>).Dec 22 2014, 12:39 PM

Changes (2)

Path

Size

dirmngr/

ldapserver.c

sm/

gpgsm.c

rGabd5f6752d69

View Options

dirmngr/ldapserver.c