Home GnuPG
Diffusion GnuPG cf8d89b0ce69

gpg: Print better diagnostics for keyserver operations.
cf8d89b0ce69Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

gpg: Print better diagnostics for keyserver operations.

* g10/armor.c (parse_key_failed_line): New.
(check_input): Watch out for gpgkeys_ error lines.
* g10/filter.h (armor_filter_context_t): Add field key_failed_code.
* g10/import.c (import): Add arg r_gpgkeys_err.
(import_keys_internal): Ditto.
(import_keys_stream): Ditto.
* g10/keyserver.c (keyserver_errstr): New.
(keyserver_spawn): Detect "KEY " lines while sending.  Get gpgkeys_err
while receiving keys.
(keyserver_work): Add kludge for better error messages.

Note that these changes can be backported to 1.4 but they don't make
sense for 2.1 due to the removal of the keyserver helpers. The error
reporting could be improved even more but given that this is an old
GnuPG branch it is not justified to put too much effort into it.

[dkg: rebased to STABLE-BRANCH-1-4]

  • GnuPG-bug-id: T1832
  • Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Details

Provenance
wernerAuthored on Feb 22 2015, 5:10 AM
Parents
rG57af33d9e7c9: Use inline functions to convert buffer data to scalars.
Branches
Unknown
Tags
Unknown

Event Timeline