g10: Always save standard revocation certificate in file.
Needs Verificationebc65ff459e6
Actions

Description

g10: Always save standard revocation certificate in file.

* g10/main.h (open_outfile): New parameter NO_OUTFILE.
* g10/openfile.c (open_outfile): New parameter NO_OUTFILE.  If given,
never use opt.outfile.
* g10/revoke.c (create_revocation): If FILENAME is true, also set
NO_OUTFILE to true (for standard revocation certificates).
* g10/dearmor.c, g10/encrypt.c, g10/export.c, g10/revoke.c,
g10/sign.c: Adjust all other callers.

Signed-off-by: Marcus Brinkmann <mb@g10code.com>
GnuPG-bug-id: T3015

Details

Auditors

• werner

Provenance

marcus

Authored on Aug 1 2017, 5:41 PM

Parents

rGa8d0b8d2333d: artwork: Add icons.

Branches

Unknown

Tags

Unknown

Reverted By

rG624cd2d0bf6c: Revert "g10: Always save standard revocation certificate in file."

Tasks

T3015: No rev cert saved if --gen-key in used with --output

Event Timeline

marcus added a task: T3015: No rev cert saved if --gen-key in used with --output.Aug 1 2017, 5:47 PM

marcus committed rGebc65ff459e6: g10: Always save standard revocation certificate in file. (authored by marcus).Aug 1 2017, 5:41 PM

marcus mentioned this in T3015: No rev cert saved if --gen-key in used with --output.Aug 1 2017, 5:47 PM

I don't like this patch because it is too large for what it achieves. The common way how we override global options is to save the old option, set that option, process, and the restore the option. In the revoke code we already do this for opt.armor.

Also you should not mix input and output parameters. In open_outfile the result was the last parameter, which is now followed by an input flag.

BTW, when adding new args to functions it is always good to take the extra work and pass ctrl_t as first arg. This will help eventually us to allow for multiple connections to gpg (server mode, like we do in gpgsm).

This commit now has outstanding concerns.Aug 1 2017, 6:37 PM

marcus added a reverting change: rG624cd2d0bf6c: Revert "g10: Always save standard revocation certificate in file.".Aug 1 2017, 7:09 PM

marcus mentioned this in rG624cd2d0bf6c: Revert "g10: Always save standard revocation certificate in file.".

Was reverted.

This commit now requires verification by auditors.Aug 7 2017, 8:08 PM