Add helper returning the version number of the Gpg4win release
The version may contain a product-specific prefix which the new helper
strips off.
- GnuPG-bug-id: T5663
Description
Description
Details
Details
- Auditors
bernhard - Provenance
ikloecker Authored on Oct 20 2021, 1:24 PM - Parents
- rLIBKLEO6fca33aa1aa7: Bump library version
- Branches
- Unknown
- Tags
- Tasks
- T5663: Kleopatra's "Check for updates" does not work
Event Timeline
Comment Actions
@ikloecker I've added the following inline comment above (but I am not sure if it was visible, it still says "unsubmitted", whatever that means)
I've also experimentally pressed "raise concern" hoping it would by inline comment visible. Anyway I've meant to only make a suggestion:
"""
If a version number like "3.1.17-dev1" is used which would be a semver.org (9.) compatible version number, does the regex work fine or is it greedy?
Suggestion
"^[^-]*-" to match first hyphen charakter.
"""
| /src/utils/gnupg.cpp | ||
|---|---|---|
| 221 | If a version number like "3.1.17-dev1" is used which would be a semver.org (9.) compatible version number, does the regex work fine or is it greedy? Suggestion | |
Comment Actions
(Ah seems I needed to do any comment, before the inline comment was published at all.)
Comment Actions
Good point. I have added support for semantic versioning to Kleo::gpg4winVersionNumber().
This comment was removed by aheinecke.