Home GnuPG
Diffusion Libkleo 93c2cff8da73

Don't use F_OK constant which is not defined on Windows
93c2cff8da73
Actions

Description

Don't use F_OK constant which is not defined on Windows

The MS documentation for the access() function only list numerical constants.

Details

Provenance
dvratilAuthored on Nov 5 2020, 6:21 PM
Parents
rLIBKLEOdb55799187cd: Use _stricmp instead of strcasecmp when building with MSVC
Branches
Unknown
Tags
Unknown

Event Timeline

dvratil committed rLIBKLEO93c2cff8da73: Don't use F_OK constant which is not defined on Windows (authored by dvratil).Nov 5 2020, 6:21 PM
• werner added a subscriber: • werner.Nov 6 2020, 8:34 AM

For portability reasons it would be better to define F_OK if is is not defined.

#if _WIN32
# ifndef F_OK
#  define F_OK 0
# endif
#endif

Does not work if it is an enum - but that is usually not the case.

• ikloecker added a subscriber: • ikloecker.Nov 6 2020, 10:07 AM

In general, I agree. But, given that the whole file is Windows-only and highly Windows-specific (dealing with the Windows registry), does it make sense in this case?

Also, I'm wondering if Daniel sees your comment since the real repo lives on invent.kde.org.

Changes (1)

PathSize
src/
utils/

rLIBKLEO93c2cff8da73

View Options

src/utils/gnupg-registry.c

Loading...