Home GnuPG
Diffusion GPGME 53c5b9a265d3

json: Do not put FILE_NAME into the verify result.

Description

json: Do not put FILE_NAME into the verify result.

* src/gpgme-json.c (verify_result_to_json): Remove "file_name".

Having the file name in the verify result may lead developers to
assume that the file name is covered by the signature. This is not
the case and can easily be checked by hex-editing a signed message.
We better don't output it at all.

The same is true for the is_mime flag but that is anyway only an
advisory and I can't see damage from a faulty one.

Note that we keep file_name in gpgme's output for ABI stability and
because some tools want to display meta information even if they are
subject to tampering. This is similar to the non-encrypted subject in
mails.

  • Signed-off-by: Werner Koch <wk@gnupg.org>

Details

Provenance
wernerAuthored on Aug 27 2018, 11:42 AM
Parents
rM702566b36c11: doc: Add warning that FILE_NAME is not part of the signed data.
Branches
Unknown
Tags
Unknown