Home GnuPG
Diffusion GPGME 5942b0c7e059

Fix returning new signatures when there are none.
5942b0c7e059Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fix returning new signatures when there are none.

* src/sign.c (gpgme_op_sign_result): Test that invalid and valid
signatures add up to gpgme_signers_count().

When invalid and valid signatures do not equal gpgme_signers_count() it
means that there was a bad passphrase during signing after the first
signer. This leaves the result.signatures from previous signers intact
which isn't correct since gpg will report:

gpg: number of one-pass packets does not match number of signature
packets
gpg: can't handle this ambiguous signature data

during verify. So when this happens append the valid signatures to the
.invalid_signers list with .reason set to GPG_ERR_GENERAL.

Details

Provenance
bjkAuthored on Nov 9 2014, 10:42 PM
wernerCommitted on Nov 21 2014, 8:25 PM
Parents
rMa9ae0d142864: doc: Clarify the FILE command.
Branches
Unknown
Tags
Unknown

Event Timeline

Werner Koch <wk@gnupg.org> committed rM5942b0c7e059: Fix returning new signatures when there are none. (authored by Ben Kibbey <bjk@luxsci.net>).Nov 21 2014, 8:25 PM