python/tests: try to decrypt and verify new test data
bd2d282e572b
Actions

Description

python/tests: try to decrypt and verify new test data

* lang/python/tests/t-decrypt.py: test decryption of cipher-3.asc and
cipher-no-sig.asc
* lang/python/tests/t-decrypt-verify.py: test decryption and
verification of cipher-3.asc and cipher-no-sig.asc

note that this introduces a failed test -- decrypt-verify.py
misbehaves on cipher-3.asc by throwing a BadSignature even though

GnuPG-bug-id: T4276
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Details

Provenance

dkg	Authored on May 3 2019, 4:16 AM

Parents

rMc5c3a9d10be4: tests: add two new types of encrypted data

Branches

Unknown

Tags

Unknown

Tasks

T4276: Context.decrypt() throws an error if *any* signature is bad

Event Timeline

dkg committed rMbd2d282e572b: python/tests: try to decrypt and verify new test data (authored by dkg).May 3 2019, 4:23 AM

dkg added a task: T4276: Context.decrypt() throws an error if *any* signature is bad.May 6 2019, 8:41 AM

Hi!

Can you please explain the commit messages. It seems the message was truncated.
And a failed test is a no-go in the regression test suite. A make check fails and thus the make release (or make distcheck) won't work either.

• werner mentioned this in rM7d0a979c07d2: python: Fix regression in t-decrypt-verify test..Jun 13 2019, 3:36 PM

Sorry for the truncated commit. the sentence should have been:

note that this introduces a failed test -- decrypt-verify.py misbehaves on cipher-3.asc by throwing a BadSignature even though the message was signed by a known key.

The subsequent commit (4100794e305ba22241ea5a4f7b42bb5189fbd948) should fix the failed test.

Unfortunately this is not the case. I had to remove the test code from t-decrypt-verify.c (7d0a979c07d2) to let "make check" work.

i think you mean t-decrypt-verify.py, right? That seems to indicate a problem on the targeted system that we ought to fix, rather than just commenting out the test. t-decrypt-verify.py passes for me when i test it with python 3.7.3 (debian python 3.7.3-1). what version of python are you testing with?